Skip to content

feat: add C implementation for stats/base/ndarray/snanmax#10198

Merged
Planeshifter merged 2 commits intostdlib-js:developfrom
Erennn7:feat/stats-base-ndarray-snanmax-native
Feb 15, 2026
Merged

feat: add C implementation for stats/base/ndarray/snanmax#10198
Planeshifter merged 2 commits intostdlib-js:developfrom
Erennn7:feat/stats-base-ndarray-snanmax-native

Conversation

@Erennn7
Copy link
Contributor

@Erennn7 Erennn7 commented Feb 10, 2026 •
edited
Loading

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: na
  • task: lint_javascript_src tatus: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: missing_dependencies
  • task: lint_c_examples status: missing_dependencies
  • task: lint_c_benchmarks status: missing_dependencies
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Resolves #{{TODO: add issue number}}.

Description

What is the purpose of this pull request?

This pull request:

  • add C implementation for stats/base/ndarray/snanmax

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 10, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 10, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/ndarray/snanmax $\color{green}170/170$
$\color{green}+0.00%$ 		$\color{green}7/7$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}170/170$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@Erennn7 Erennn7 force-pushed the feat/stats-base-ndarray-snanmax-native branch from 77c3ddb to 0f3dd20 Compare February 10, 2026 13:10
Sachinn-64
Sachinn-64 requested changes Feb 11, 2026
View reviewed changes
Copy link
Member

@Sachinn-64 Sachinn-64 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Erennn7 You could refactor the test.js implementation. Refer to #9981

@Sachinn-64 Sachinn-64 added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 11, 2026
@Erennn7 Erennn7 force-pushed the feat/stats-base-ndarray-snanmax-native branch from 0f3dd20 to 6d6f433 Compare February 12, 2026 18:47
@Sachinn-64
chore: minor cleanup
acbf3a2 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Sachinn-64 Sachinn-64 added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Feb 12, 2026
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 15, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 15, 2026

PR Commit Message

feat: add C implementation for `stats/base/ndarray/snanmax`

PR-URL: https://github.com/stdlib-js/stdlib/pull/10198

Co-authored-by: orthodox-64 <sachinprogramming62@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Sachinn-64 <Sachinn-64@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 15, 2026
@Planeshifter Planeshifter merged commit 8bfb552 into stdlib-js:develop Feb 15, 2026
49 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@Sachinn-64 Sachinn-64 Sachinn-64 approved these changes

Assignees

No one assigned

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Erennn7 @stdlib-bot @Planeshifter @Sachinn-64